When You're Smiling is distinguished by the presence of several top recording artists of 1950. The wafer-thin plotline concerns the misadventures of Texan Gerald Durham (Jerome Courtland), who arrives in the Big City to learn the ropes of the music business. Durham not only ends up with a recording contract, but also wins heroine Peggy Martin (Lola Albright) in the bargain. So much for the story. The principal selling card of When You're Smiling consists of the guest-star turns by Frankie Laine, Bob Crosby, The Modernaires, The Mills Brothers, Kay Starr and Billy Daniels.
~ Hal Erickson, All Movie Guide